ROB: Capture UnicodeDecodeError at PdfReader.pdf_header #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MartinThoma |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 34 34
Lines 6576 6581 +5
Branches 1301 1302 +1
=======================================
+ Hits 6077 6082 +5
Misses 326 326
Partials 173 173
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
MartinThoma
changed the title
MartinThoma
added
the
is-robustness-issue
|
I love it ❤️ |
This was referenced Apr 6, 2023
Closed
MartinThoma
added a commit
that referenced
this pull request
Apr 9, 2023
Security (SEC): - Warn about PDF encryption security (#1755) Robustness (ROB): - Prevent loop in Cloning (#1770) - Capture UnicodeDecodeError at PdfReader.pdf_header (#1768) Documentation (DOC): - Pin myst_parser==0.16.1 and rename .readthedocs.yaml (#1752) - Add readthedocs.yml and bump docs dependencies using `tox -e deps` (#1750) Developer Experience (DEV): - Make make_changelog.py idempotent Maintenance (MAINT): - Move generation of file identifiers to a method (#1760) Testing (TST): - Add xmp test (#1775) Code Style (STY): - Improve language, add docstrings, fix TODOs (#1772) - Test names, docstrings, and parametrization (#1771) [Full Changelog](3.7.0...3.7.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1758
This is an alternative which also reports when "opening" the file a damaged header
Change to the check of footer (log in case of not strict) should be better for linearization
also pdf_header should report the actual header for better understanding