Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: ignore "/B" fields only on pages in PdfWriter.append() #1875

Merged
merged 6 commits into from
Jun 24, 2023

Conversation

pubpub-zz
Copy link
Collaborator

Closes #1862

add capability to limit ignore_fields propagation during cloning process

Closes py-pdf#1862

add capability to limit ignore_fields propagation during  cloning process
@pubpub-zz pubpub-zz marked this pull request as ready for review June 9, 2023 18:06
@pubpub-zz
Copy link
Collaborator Author

the adobe server is failed 😤
https://opensource.adobe.com/dc-acrobat-sdk-docs/standards/pdfstandards/pdf/PDF32000_2008.pdf can not be loaded
we have to wait before rerunning the action

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (2213b64) 93.73% compared to head (d47fd5d) 93.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1875      +/-   ##
==========================================
+ Coverage   93.73%   93.74%   +0.01%     
==========================================
  Files          34       34              
  Lines        6795     6806      +11     
  Branches     1338     1341       +3     
==========================================
+ Hits         6369     6380      +11     
  Misses        279      279              
  Partials      147      147              
Impacted Files Coverage Δ
pypdf/_writer.py 88.75% <ø> (ø)
pypdf/generic/_base.py 100.00% <100.00%> (ø)
pypdf/generic/_data_structures.py 91.14% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
all yours

@MartinThoma MartinThoma merged commit e611f91 into py-pdf:main Jun 24, 2023
@MartinThoma
Copy link
Member

Interesting issue!

I've merged it. Thank you for investigating the problem and fixing it 🤗

@pubpub-zz pubpub-zz deleted the BMissing branch September 2, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where are B's?
2 participants