Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix AnnotationBuilder.link #2066

Merged
merged 1 commit into from
Aug 6, 2023
Merged

BUG: Fix AnnotationBuilder.link #2066

merged 1 commit into from
Aug 6, 2023

Conversation

MartinThoma
Copy link
Member

The object was not updating itself, but a temporary variable in it

Closes #2058

The object was not updating itself, but a temporary variable in it

Closes #2058
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (0987346) 94.18% compared to head (c887402) 94.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2066      +/-   ##
==========================================
+ Coverage   94.18%   94.23%   +0.05%     
==========================================
  Files          41       41              
  Lines        7340     7340              
  Branches     1445     1445              
==========================================
+ Hits         6913     6917       +4     
+ Misses        266      263       -3     
+ Partials      161      160       -1     
Files Changed Coverage Δ
pypdf/annotations/_markup_annotations.py 96.63% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinThoma MartinThoma merged commit 7e9292c into main Aug 6, 2023
@MartinThoma MartinThoma deleted the 2058/fix-link branch August 6, 2023 07:30
MartinThoma added a commit that referenced this pull request Aug 6, 2023
### New Features (ENH)
-  Add `level` parameter to compress_content_streams (#2044)
-  Process /uniHHHH for text_extract (#2043)

### Bug Fixes (BUG)
-  Fix AnnotationBuilder.link (#2066)
-  JPX image without ColorSpace  (#2062)
-  Added check for field /Info when cloning reader document (#2055)
-  Fix indexed/CMYK images (#2039)

### Maintenance (MAINT)
-  Cryptography as primary dependency (#2053)

[Full Changelog](3.14.0...3.15.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link in the new (3.14.0) annotation module returns an empty dict.
1 participant