MAINT: Enable disallow_any_generics and add missing generics.
#2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, I don't see how the failing test is related to my changes. Could it be a spurious failure? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2278 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 43 43
Lines 7654 7654
Branches 1513 1513
=======================================
Hits 7225 7225
Misses 266 266
Partials 163 163 ☔ View full report in Codecov by Sentry. |
MartinThoma
changed the title
disallow_any_generics and add missing generics.disallow_any_generics and add missing generics.
|
@nilehmann Thank your for the improvements! It will be part of the next release (latest in ~2 weeks) |
MartinThoma
added a commit
that referenced
this pull request
Dec 10, 2023
## What's new ### Bug Fixes (BUG) - Cope with deflated images with CMYK Black Only (#2322) by @pubpub-zz - Handle indirect objects as parameters for CCITTFaxDecode (#2307) by @stefan6419846 - check words length in _cmap type1_alternative function (#2310) by @Takher ### Robustness (ROB) - Relax flate decoding for too many lookup values (#2331) by @stefan6419846 - Let _build_destination skip in case of missing /D key (#2018) by @nickryand ### Documentation (DOC) - Note in reading form data (#2338) by @MartinThoma - Pull Request prefixes and size by @MartinThoma - Add https://github.com/zuypt for #2325 as a contributor by @MartinThoma - Fix docstring for RunLengthDecode.decode (#2302) by @stefan6419846 ### Maintenance (MAINT) - Enable `disallow_any_generics` and add missing generics (#2278) by @nilehmann ### Testing (TST) - Centralize file downloads (#2324) by @MartinThoma ### Code Style (STY) - Fix typo "steam" \xe2\x86\x92 "stream" (#2327) by @stefan6419846 - Run black by @MartinThoma - Make Traceback in bug report template uppercase (#2304) by @stefan6419846 [Full Changelog](3.17.1...3.17.2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #2272
Enable the
disallow_any_genericsoption and add missing generics. Also, add some overloaded versions ofapply_onto avoid some casts.I'm not sure what's the best way to fix this, but
EncryptAlgorihmgives meTypeError: 'EncryptAlgorithm': too many data types: [<class 'tuple'>, <class 'typing.Generic'>]if I make it a subclass ofTupe[Any, ...]so I left it as is and ignored the error.