Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Test against Python 3.13 #2776

Merged
merged 7 commits into from
Jul 28, 2024
Merged

DEV: Test against Python 3.13 #2776

merged 7 commits into from
Jul 28, 2024

Conversation

stefan6419846
Copy link
Collaborator

Let's start testing against Python 3.13, which is soon to be planned to have its first release candidate. Prior testing has shown that the latest dependencies work fine, let's see if our pinned dependencies are recent enough.

@stefan6419846
Copy link
Collaborator Author

Somehow the tests on Python 3.13 are significantly slower than on the other Python versions at the moment and report a warning:

/opt/hostedtoolcache/Python/3.13.0-beta.4/x64/lib/python3.13/site-packages/coverage/pytracer.py:320: CoverageWarning: Trace function changed, data is likely wrong: None != <bound method PyTracer._trace of <PyTracer at 0x7faefd1125d0: 5476 data points in 25 files>> (trace-changed)

The speed is the reason for the failing test as well.

From independent prior testing without having the dependencies pinned, id est using the latest version of each dependency, the execution speed looked normal. Thus, it seems like we might need some further library updates here (maybe for coverage.py only), but this is something we still have to further evaluate.

@stefan6419846
Copy link
Collaborator Author

It seems like updating the coverage package did indeed fix the speed issues for Python 3.13, thus I consider this PR ready for merging.

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (d40fcc1) to head (972b7e8).
Report is 76 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2776   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files          51       51           
  Lines        8553     8553           
  Branches     1706     1706           
=======================================
  Hits         8136     8136           
  Misses        263      263           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz pubpub-zz merged commit 4bd54bd into main Jul 28, 2024
17 checks passed
@pubpub-zz pubpub-zz deleted the python3-13 branch July 28, 2024 15:16
@pubpub-zz
Copy link
Collaborator

good job to have this new coverage

@pubpub-zz pubpub-zz mentioned this pull request Sep 15, 2024
pubpub-zz added a commit that referenced this pull request Sep 17, 2024
## Version 5.0.0, 2024-09-15

This version drops support for Python 3.7 (not maintained since July 2023), PdfMerger (use PdfWriter instead) and AnnotationBuilder (use annotations instead).


### Deprecations (DEP)
- Remove the deprecated PfdMerger and AnnotationBuilder classes and other deprecations cleanup (#2813)
- Drop Python 3.7 support (#2793)

### New Features (ENH)
- Add capability to remove /Info from PDF (#2820)
- Add incremental capability to PdfWriter (#2811)
- Add UniGB-UTF16 encodings (#2819)
- Accept utf strings for metadata (#2802)
- Report PdfReadError instead of RecursionError (#2800)
- Compress PDF files merging identical objects (#2795)

### Bug Fixes (BUG)
- Fix sheared image (#2801)

### Robustness (ROB)
- Robustify .set_data() (#2821)
- Raise PdfReadError when missing /Root in trailer (#2808)
- Fix extract_text() issues on damaged PDFs (#2760)
- Handle images with empty data when processing an image from bytes (#2786)

### Developer Experience (DEV)
- Fix coverage uploads (#2832)
- Test against Python 3.13 (#2776)


[Full Changelog](4.3.1...5.0.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants