DEV: make make_release.py compatible with windows environment #2894
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2894 +/- ##
==========================================
+ Coverage 96.43% 96.44% +0.01%
==========================================
Files 52 52
Lines 8726 8726
Branches 1721 1589 -132
==========================================
+ Hits 8415 8416 +1
Misses 182 182
+ Partials 129 128 -1 ☔ View full report in Codecov by Sentry. |
|
the doc compilation failed randomly. This should be OK |
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
|
Could you please add a test to cover the |
|
I have no client on how to test a program file not within tests folder |
|
There is nothing special about this, see the existing test: https://github.com/py-pdf/pypdf/blob/main/tests/scripts/test_make_release.py |
Can you clarify what error did you get and what was the commit_hash value ? |
|
I would still prefer to see a test added here.
Which indicates that an author could not be mapped. In theory, this should not occur, although there might be edge cases. Nevertheless, this should probably be fixed and tested as well. |
Agréé. in progress
Agree. I had a similar issue this is why I completed the strip() waiting for feedback from @MartinThoma |
|
It was a key-not-found error - the the hash was not in the dictionary. I haven't looked more into it. |
|
@MartinThoma |
This is not surprising as this script is only intended for the default branch. Running on other branches would require different GitHub API requests. |
I agree this is not the objective of this script. I've added the test based on what I've internally objerved in windows. Ready for review |
|
While the Windows CI breaks because of broken test file downloads, merging is not possible for now. We should probably wait some time before re-running it to avoid rate limit errors. |
|
I never understood why the files seem to be properly cached in ubuntu but not in windows any ideas? |
|
Windows does not use the cache as it is not configured there. |
shouldn't we set it up ? |
|
At the moment, this helps detecting invalid links which are not available any more. Thus I am not completely sure about this. |
## What's new ### New Features (ENH) - Add `layout_mode_font_height_weight` argument to `PageObject.extract_text()` (#2920) by @hpierre001 ### Bug Fixes (BUG) - Fix font specificier for FreeText annotation (#2893) by @ssjkamei - Line breaks are not generated due to incorrect calculation of text leading (#2890) by @ssjkamei - Improve handling of spaces in text extraction (#2882) by @ssjkamei ### Robustness (ROB) - Soft failure for flate encode image mode 1 with wrong LUT size (#2900) by @stefan6419846 ### Documentation (DOC) - Use latest package versions (#2907) by @stefan6419846 - Correct example of reading FileAttachment annotation (#2906) by @j-t-1 ### Developer Experience (DEV) - Update pinned requirements (#2918) by @stefan6419846 - Make make_release.py compatible with Windows environment (#2894) by @pubpub-zz ### Maintenance (MAINT) - Remove references to outdated Python versions (#2919) by @stefan6419846 - Generalize the method of obtaining space_code (#2891) by @ssjkamei - Unnecessary character mapping process (#2888) by @ssjkamei - New LZW decoding implementation (#2887) by @MartinThoma ### Testing (TST) - Add LzwCodec for encoding (#2883) by @MartinThoma ### Code Style (STY) - Capitalize error messages (#2903) by @j-t-1 - Modify error messages in PdfWriter (#2902) by @j-t-1 [Full Changelog](5.0.1...5.1.0)
No description provided.