Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: Use startswith #2969

Merged
merged 2 commits into from
Nov 28, 2024
Merged

STY: Use startswith #2969

merged 2 commits into from
Nov 28, 2024

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Nov 28, 2024

No description provided.

@j-t-1 j-t-1 changed the title STY: Use Startswith STY: Use startswith Nov 28, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.36%. Comparing base (bd26922) to head (a1ba3b3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pypdf/_reader.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2969   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          52       52           
  Lines        8746     8746           
  Branches     1590     1590           
=======================================
  Hits         8428     8428           
  Misses        190      190           
  Partials      128      128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stefan6419846
stefan6419846 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@stefan6419846 stefan6419846 merged commit e8cb703 into py-pdf:main Nov 28, 2024
16 of 17 checks passed
@j-t-1 j-t-1 deleted the startswith branch November 28, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan6419846 stefan6419846 stefan6419846 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-t-1 @stefan6419846