Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min samples Leaf is not used in PolicyInterpreter! #286

Closed
vsyrgkanis opened this issue Oct 6, 2020 · 1 comment
Closed

Min samples Leaf is not used in PolicyInterpreter! #286

vsyrgkanis opened this issue Oct 6, 2020 · 1 comment
Assignees
@kbattocchi @moprescu @heimengqi
Labels
bug Something isn't working

Comments

@vsyrgkanis
Copy link
Collaborator

https://github.com/microsoft/EconML/blob/949c246329abfa5d1b5239e71e3e62a329bd468e/econml/cate_interpreter.py#L545

The parameter min_samples_leaf is omitted here!!
@vsyrgkanis vsyrgkanis added the bug Something isn't working label Oct 6, 2020
@kbattocchi
Copy link
Collaborator

Good catch, I'll add a commit addressing it to the bootstrap PR.

kbattocchi added a commit that referenced this issue Oct 7, 2020
@kbattocchi
Fix #280, fix #286
0490101
kbattocchi added a commit that referenced this issue Oct 7, 2020
@kbattocchi
Fix #280, fix #286
63daf39
kbattocchi added a commit that referenced this issue Oct 30, 2020
@kbattocchi
Fix #280, fix #286
f4f0bf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbattocchi kbattocchi

@moprescu moprescu

@heimengqi heimengqi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kbattocchi @vsyrgkanis @moprescu @heimengqi