Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XLearner issue with timing of clone #212

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Fix XLearner issue with timing of clone #212

merged 2 commits into from
Feb 7, 2020

Conversation

kbattocchi
Copy link
Collaborator

Currently if cate_models isn't specified in the initializer, then we end up using models for them. But then we fit those models before cloning them into cate_treated_models and cate_controls_models, while it would be better to clone them first, then train.

@kbattocchi kbattocchi marked this pull request as ready for review January 31, 2020 17:40
moprescu
moprescu approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@moprescu moprescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

@kbattocchi kbattocchi merged commit 2562abf into master Feb 7, 2020
@kbattocchi kbattocchi deleted the kebatt/xlearnerFix branch February 7, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moprescu moprescu moprescu approved these changes

@vasilismsr vasilismsr Awaiting requested review from vasilismsr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbattocchi @moprescu