Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #248

Merged
merged 9 commits into from
Aug 11, 2020
Merged

Small fixes #248

merged 9 commits into from
Aug 11, 2020

Conversation

kbattocchi
Copy link
Collaborator

@kbattocchi kbattocchi commented Apr 10, 2020 •
edited
Loading

Fixes #244. Fixes #246. Fixes #237. Fixes #251. Fixes #263.

@kbattocchi kbattocchi force-pushed the kebatt/miscFixes branch 3 times, most recently from 2761a43 to 66d8c2d Compare April 17, 2020 22:32
@kbattocchi kbattocchi force-pushed the kebatt/miscFixes branch 3 times, most recently from 51763fd to dad8dcd Compare May 8, 2020 23:49
@kbattocchi kbattocchi force-pushed the kebatt/miscFixes branch 2 times, most recently from dad8dcd to b1fec80 Compare June 9, 2020 01:46
@kbattocchi kbattocchi force-pushed the kebatt/miscFixes branch 2 times, most recently from 119ca77 to dcb96f5 Compare June 15, 2020 18:03
heimengqi
heimengqi suggested changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed by commit, almost looks great! I left only few comments, please take a look!

econml/_ortho_learner.py Show resolved Hide resolved
econml/_rlearner.py Outdated Show resolved Hide resolved
@kbattocchi kbattocchi force-pushed the kebatt/miscFixes branch 2 times, most recently from 6ea32a4 to d11b6d8 Compare August 11, 2020 06:05
@kbattocchi kbattocchi requested a review from heimengqi August 11, 2020 06:09
heimengqi
heimengqi approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good!

@kbattocchi kbattocchi merged commit c918cc0 into master Aug 11, 2020
@kbattocchi kbattocchi deleted the kebatt/miscFixes branch August 11, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimengqi heimengqi heimengqi approved these changes

@moprescu moprescu Awaiting requested review from moprescu

@vasilismsr vasilismsr Awaiting requested review from vasilismsr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kbattocchi @heimengqi