Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed SubsampledHonestForest randomness #258

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Fixed SubsampledHonestForest randomness #258

merged 3 commits into from
Jun 9, 2020

Conversation

moprescu
Copy link
Contributor

@moprescu moprescu commented Jun 9, 2020

No description provided.

@moprescu moprescu requested review from kbattocchi and vasilismsr June 9, 2020 16:10
kbattocchi
kbattocchi approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; feel free to merge once tests pass.

econml/sklearn_extensions/ensemble.py Outdated Show resolved Hide resolved
@moprescu moprescu force-pushed the moprescu/forestdml_randomness branch from 11e06f5 to 989481d Compare June 9, 2020 16:24
@moprescu moprescu merged commit 11fb0fc into master Jun 9, 2020
@moprescu moprescu deleted the moprescu/forestdml_randomness branch June 9, 2020 20:49
@kbattocchi kbattocchi mentioned this pull request Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

@vasilismsr vasilismsr Awaiting requested review from vasilismsr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moprescu @kbattocchi