Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some small fixes to the debiased lasso #358

Merged
merged 17 commits into from
Jan 9, 2021
Merged

some small fixes to the debiased lasso #358

merged 17 commits into from
Jan 9, 2021

Conversation

vsyrgkanis
Copy link
Collaborator

Small fixes to the debiased lasso implementation.

@vsyrgkanis vsyrgkanis requested a review from moprescu December 29, 2020 14:28
@vsyrgkanis vsyrgkanis added the bug Something isn't working label Dec 29, 2020
@vsyrgkanis vsyrgkanis added enhancement New feature or request and removed bug Something isn't working labels Dec 29, 2020
moprescu
moprescu approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@moprescu moprescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

econml/sklearn_extensions/linear_model.py Outdated Show resolved Hide resolved
econml/sklearn_extensions/linear_model.py Show resolved Hide resolved
@vsyrgkanis vsyrgkanis merged commit ce2f2b5 into master Jan 9, 2021
@vsyrgkanis vsyrgkanis deleted the vasilis/dblasso_fix branch January 9, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moprescu moprescu moprescu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsyrgkanis @moprescu @vasilismsr