Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lalonde notebook #448

Merged
merged 10 commits into from
May 4, 2021
Merged

add lalonde notebook #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c95b8ff
add lalonde notebook
heimengqi Apr 2, 2021
f5c9e81
add dependency
heimengqi Apr 5, 2021
ecac8f1
update notebook
ewdillon Apr 8, 2021
1c9e82f
address Nora's commments and increase the notebook running time
heimengqi Apr 13, 2021
5790c9d
address review comments
heimengqi May 3, 2021
f0ee817
Merge branch 'master' into mehei/lalondenotebook
heimengqi May 3, 2021
3a2777b
fix linting and markdown display
heimengqi May 3, 2021
4dda02a
test linting
heimengqi May 3, 2021
40b3173
add dependency back
heimengqi May 3, 2021
9874902
fix linting
heimengqi May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure-pipelines-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
condition: and(succeeded(), eq(variables['Agent.OS'], 'Linux'))

# Install the package
- script: 'pip install --upgrade setuptools wheel Cython && pip install ${{ parameters.package }}'
- script: 'python -m pip install --upgrade pip && pip install --upgrade setuptools wheel Cython && pip install ${{ parameters.package }}'
displayName: 'Install dependencies'

- ${{ parameters.job.steps }}
2 changes: 1 addition & 1 deletion econml/tests/test_notebooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def test_notebook(file):
# require all cells to complete within 15 minutes, which will help prevent us from
# creating notebooks that are annoying for our users to actually run themselves
ep = nbconvert.preprocessors.ExecutePreprocessor(
timeout=1200, allow_errors=True, extra_arguments=["--HistoryManager.enabled=False"])
timeout=1800, allow_errors=True, extra_arguments=["--HistoryManager.enabled=False"])

ep.preprocess(nb, {'metadata': {'path': _nbdir}})
errors = [nbconvert.preprocessors.CellExecutionError.from_cell_and_msg(cell, output)
Expand Down
Loading