-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dowhy_mediation_analysis.ipynb #498
Conversation
You had assign in causal_estimate_nie variable the natural direct effect and vice versa, so I corrected the typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, thanks for catching this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsoum I noticed that there is an error when running the notebook. Perhaps there is one more name change required?
NameError Traceback (most recent call last) Input In [7], in <cell line: 1>() ----> 1print(causal_estimate_nde.value, data["ate"]) NameError: name 'causal_estimate_nde' is not defined NameError: name 'causal_estimate_nde' is not defined
@amit-sharma you are right! Done! |
@amit-sharma the PR blocked because of lack of proper sign-off by me? Is there any easy and proper way to solve it? |
To solve the DCO issue, you can put all changes into one commit and update this PR. For instance, make a soft reset, take all changes together and make one new commit with |
@bloebp I have done the commits given their simplicity by the GitHub GUI. Is any way to solve the DCO issue by the GitHub GUI or I should fetch it local in my laptop and push it? |
Except by overriding the commit history of this branch and adding the missing sign offs, I don't know. Strictly speaking, they should be in there before any code is pushed. |
I've approved the DCO for this PR. All good for the merge---thanks @itsoum |
@all-contributors please add @itsoum for code. |
I've put up a pull request to add @itsoum! 🎉 |
You had assign in causal_estimate_nie variable the natural direct effect and vice versa, so I corrected the typo.