Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sphinx_design to docdeps #992

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Conversation

darthtrevino
Copy link
Collaborator

I was installing dowhy with our intern, and noticed that the sphinx dependencies were being pulled in. These should only be installed when building the docsite.

Signed-off-by: Chris Trevino <chtrevin@microsoft.com>
amit-sharma
amit-sharma previously approved these changes Jul 28, 2023
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Edit: This update somehow downgrades econml from 0.14 to 0.13. Can you look into that? It's leading to a build failure.

@amit-sharma amit-sharma self-requested a review July 28, 2023 04:00
@amit-sharma amit-sharma dismissed their stale review July 28, 2023 04:00

saw a build error

Signed-off-by: Amit Sharma <amit_sharma@live.com>
…or otherwise)

Signed-off-by: Amit Sharma <amit_sharma@live.com>
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I updated a np.float error due to numpy 1.24.1 and it passes the tests now (in addition to enforcing econml >=0.14.1)

@amit-sharma amit-sharma merged commit 44a6d99 into main Jul 30, 2023
@amit-sharma amit-sharma deleted the task/move_sphinx_to_doc_deps branch July 30, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants