Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD - Adding installation checkers #489

Merged
merged 19 commits into from
Aug 29, 2023
Merged

Conversation

alex-rakowski
Copy link
Collaborator

This adds three different level of installation checks:

  • quick makes sure any PR/Push to any branch, except main and dev, can be installed and imported on Python 3.10, on Ubuntu
  • dev makes sure any PR/Push to dev can be installed and imported on python 3.9-3.11 on ubuntu
  • main makes sure any PR/Push to main can be installed and imported on python 3.9-3.11 on mac, ubuntu and windows, and checks but allows fail if it is compatible with 3.12

All have their ability to check against Apple silicon commented out to be ready when that image is available.

@alex-rakowski
Copy link
Collaborator Author

We should probably update the pypi_upload.yml to be dependent on these checks.

@bsavitzky
Copy link
Member

These look great, thanks @alex-rakowski . Let's wait until after the MM rush to review and accept these, they will be very helpful

@alex-rakowski
Copy link
Collaborator Author

Sounds good, I misread an issue on the slack channel and thought this solved a pre M&M need

@alex-rakowski
Copy link
Collaborator Author

Removed 3.9 checks

@sezelt sezelt merged commit fb01fa4 into py4dstem:dev Aug 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants