Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRS hot fixes #581

Merged
merged 1 commit into from
Nov 23, 2023
Merged

MRS hot fixes #581

merged 1 commit into from
Nov 23, 2023

Conversation

smribet
Copy link
Collaborator

@smribet smribet commented Nov 22, 2023

This PR has a refactor of the strain plotting functions. The strain notebooks and WS2 ACOM example work here.
tutorials.zip

Copy link
Collaborator

@alex-rakowski alex-rakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only comment is we now have exx and e_xx etc. used in different places, and should we standardise to one across everything at somepoint

Copy link
Collaborator

@alex-rakowski alex-rakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only comment is we now have exx and e_xx etc. used in different places, and should we standardise to one across everything at somepoint

@bsavitzky bsavitzky merged commit 8408ea3 into py4dstem:dev Nov 23, 2023
7 checks passed
@smribet smribet deleted the mrs_hot_fix branch November 30, 2023 21:50
bsavitzky added a commit to bsavitzky/py4DSTEM that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants