Update polar_analysis.py #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to allow calculation of pdfs from single points or small areas Main point was to replace calls to self.radial_mean with defining Ik either as self.radial_mean or areas selected/averaged from self.radial_all Some minor updates were also needed in plot_background_fits Some doc strings added
Minor typos
Fixed ylim scaling issue in plot_background_fits
|
This is great, thanks @maclariz! Should we update the initial guess for the background coefficients to use Ik as well (line 346/346) of |
|
You're absolutely right. These were initial guess for an optimisation so it probably didn't make any difference when I ran it since it probably found the minimum anyway. However, this is probably closer for sub-areas and better practice. |
|
Awesome, thanks! |
smribet
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to allow calculation of rdfs from single points or small areas
Main point was to replace calls to self.radial_mean with defining Ik either as self.radial_mean or areas selected/averaged from self.radial_all
Some minor updates were also needed in plot_background_fits
Some doc strings added
The one weakness in my code is that the rdf from the sub area is then attached to self as representative of whole dataset. This doesn't worry me for now. If I want a different sub-area, I can recalculate. But you may wish to do point by point calculation over entire dataset at some point.