Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Discharged energy [W.h] as variable #1575

Closed
TomTranter opened this issue Jul 28, 2021 · 4 comments · Fixed by #1969
Closed

Add Discharged energy [W.h] as variable #1575

TomTranter opened this issue Jul 28, 2021 · 4 comments · Fixed by #1969
Assignees
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours feature

Comments

@TomTranter
Copy link
Contributor

Summary
Add Discharged energy [W.h] as variable

Motivation
Like discharged capacity but using current * voltage. Useful for performance metrics and minimal overhead

@TomTranter TomTranter self-assigned this Jul 28, 2021
@valentinsulzer
Copy link
Member

Took a look at how you started this. You don't need to create a new pybamm.Variable for discharged energy, just calculate it as a post-processing step

@TomTranter
Copy link
Contributor Author

Ok - is there an official way to do this? Or you just mean manually with the entries

@valentinsulzer
Copy link
Member

add it to this function somewhere

def set_voltage_variables(self):

@brosaplanella brosaplanella added the difficulty: easy A good issue for someone new. Can be done in a few hours label Nov 11, 2021
@valentinsulzer
Copy link
Member

My bad, you do need an additional variable

@valentinsulzer valentinsulzer self-assigned this Mar 8, 2022
valentinsulzer added a commit that referenced this issue Mar 8, 2022
valentinsulzer added a commit that referenced this issue Mar 8, 2022
valentinsulzer added a commit that referenced this issue Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants