Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example notebooks and scripts assume scikits.odes is installed #463

Closed
martinjrobins opened this issue Jun 6, 2019 · 1 comment · Fixed by #800
Closed

example notebooks and scripts assume scikits.odes is installed #463

martinjrobins opened this issue Jun 6, 2019 · 1 comment · Fixed by #800
Assignees
@valentinsulzer
Labels
bug Something isn't working

Comments

@martinjrobins
Copy link
Contributor

need to figure out a good way to skip those that use it, or to put a check in the notebooks themselves
@martinjrobins martinjrobins added the bug Something isn't working label Jun 6, 2019
@valentinsulzer valentinsulzer mentioned this issue Nov 7, 2019
Merged
8 tasks
@valentinsulzer valentinsulzer self-assigned this Nov 7, 2019
@valentinsulzer
Copy link
Member

Can be fixed now we have casadi:

  • Add if/else to the relevant examples to use casadi solvers where necessary
  • Test examples both with and without optional dependencies

valentinsulzer added a commit that referenced this issue Dec 7, 2019
@valentinsulzer
#463 reformatting notebooks
b5bdc4f
valentinsulzer added a commit that referenced this issue Dec 7, 2019
@valentinsulzer
#463 merge master
ff683b4
@valentinsulzer valentinsulzer mentioned this issue Jan 28, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 784 simplify solver pybamm-team/PyBaMM
2 participants
@martinjrobins @valentinsulzer