Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on Mac install (ft. sinister error message) #646

Closed
valentinsulzer opened this issue Oct 4, 2019 · 2 comments · Fixed by #680
Closed

Bug on Mac install (ft. sinister error message) #646

valentinsulzer opened this issue Oct 4, 2019 · 2 comments · Fixed by #680
Labels
bug Something isn't working

Comments

@valentinsulzer
Copy link
Member

After running pip install -e .[dev,docs] and python3 run-tests.py --unit, test_symobl_visualise fails (hopefully just needs an extra dependency).
NB - I don't know who thought it would be a good idea to call a function _execute_child

======================================================================
ERROR: test_symbol_visualise (test_expression_tree.test_symbol.TestSymbol)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/vsulzer/Documents/PyBaMM/tests/unit/test_expression_tree/test_symbol.py", line 312, in test_symbol_visualise
    rhs.visualise("StefanMaxwell_test.png")
  File "/Users/vsulzer/Documents/PyBaMM/pybamm/expression_tree/symbol.py", line 224, in visualise
    ).to_picture(filename)
  File "/Users/vsulzer/Documents/PyBaMM/PyBaMM-env/lib/python3.7/site-packages/anytree/exporter/dotexporter.py", line 268, in to_picture
    check_call(cmd)
  File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 342, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 323, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/local/Cellar/python/3.7.4_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 1522, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'dot': 'dot'
@valentinsulzer valentinsulzer added the bug Something isn't working label Oct 4, 2019
@martinjrobins
Copy link
Contributor

looks like graphviz needs to be added as a dependency for PyBaMM. This provides the dot executable. Note this isn't pip installable, so user would have to install manually (https://graphviz.gitlab.io/download/)

@brosaplanella
Copy link
Sponsor Member

I noticed that when I ran the tests in my computer one failed (which was related to this dot thing).

valentinsulzer pushed a commit that referenced this issue Oct 25, 2019
valentinsulzer pushed a commit that referenced this issue Oct 25, 2019
@valentinsulzer valentinsulzer mentioned this issue Oct 25, 2019
8 tasks
valentinsulzer added a commit that referenced this issue Oct 25, 2019
valentinsulzer added a commit that referenced this issue Oct 26, 2019
valentinsulzer added a commit that referenced this issue Oct 26, 2019
valentinsulzer pushed a commit that referenced this issue Oct 26, 2019
@valentinsulzer valentinsulzer mentioned this issue Oct 28, 2019
8 tasks
valentinsulzer added a commit that referenced this issue Nov 8, 2019
valentinsulzer added a commit that referenced this issue Nov 8, 2019
valentinsulzer added a commit that referenced this issue Nov 8, 2019
valentinsulzer added a commit that referenced this issue Feb 10, 2020
valentinsulzer added a commit that referenced this issue Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants