Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electrolyte thermal dependence #678

Closed
rtimms opened this issue Oct 24, 2019 · 0 comments · Fixed by #698
Closed

Electrolyte thermal dependence #678

rtimms opened this issue Oct 24, 2019 · 0 comments · Fixed by #698
Assignees
@rtimms

Comments

@rtimms
Copy link
Contributor

rtimms commented Oct 24, 2019

In the electrolyte submodels the temperature which appears in front of the pybamm.grad(c_e)/c_e is missing (should be (1+param.Theta*T) * pybamm.grad(c_e)/c_e ). This term is also missing inside butler-volmer. The results is that some terms are evaluated at the reference temperature
@rtimms rtimms self-assigned this Oct 24, 2019
rtimms added a commit that referenced this issue Oct 30, 2019
@rtimms
#678 fix dimension typo
5143e07
rtimms added a commit that referenced this issue Oct 30, 2019
@rtimms
#678 thermal comparison
84206d5
rtimms added a commit that referenced this issue Oct 30, 2019
@rtimms
#678 fix cooling
ca01dd7
rtimms added a commit that referenced this issue Oct 30, 2019
@rtimms
#678 adding missing electrolyte temp dependence
2750870
rtimms added a commit that referenced this issue Oct 30, 2019
@rtimms
#678 debug electrolyte
57c73c7
rtimms added a commit that referenced this issue Oct 30, 2019
@rtimms
#678 fix temp depend kinetics
9940bf7
rtimms added a commit that referenced this issue Oct 31, 2019
@rtimms
#678 fix add subtract simplify bug
77778a6
rtimms added a commit that referenced this issue Oct 31, 2019
@rtimms
#678 add temp depend to backward tafel
b377dad
@rtimms rtimms mentioned this issue Oct 31, 2019
Merged
6 tasks
rtimms added a commit that referenced this issue Oct 31, 2019
@rtimms
#678 update changelog
b89df67
rtimms added a commit that referenced this issue Oct 31, 2019
@rtimms
#678 fix set temperature script
379c957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 678 eleclyte temp depend pybamm-team/PyBaMM
1 participant
@rtimms