Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current data gets scaled by I_typ #851

Closed
rtimms opened this issue Feb 24, 2020 · 0 comments · Fixed by #852
Closed

Current data gets scaled by I_typ #851

rtimms opened this issue Feb 24, 2020 · 0 comments · Fixed by #852
Assignees
@rtimms
Labels
bug Something isn't working

Comments

@rtimms
Copy link
Contributor

rtimms commented Feb 24, 2020

When loading in current data it gets scaled by I_typ. This is happening during check_and_update_parameter_values - when updating the C-rate to be the current data/capacity, the current data is also being altered
@rtimms rtimms added the bug Something isn't working label Feb 24, 2020
@rtimms rtimms self-assigned this Feb 24, 2020
rtimms added a commit that referenced this issue Feb 24, 2020
@rtimms
#851 fix scaling bug in current data
be8fc10
@rtimms rtimms mentioned this issue Feb 24, 2020
Merged
8 tasks
rtimms added a commit that referenced this issue Feb 24, 2020
@rtimms
[ci skip] #851 changelog
caa52a6
rtimms added a commit that referenced this issue Feb 24, 2020
@rtimms
Merge pull request #852 from pybamm-team/issue-851-current-data-scale
e517122 
#851 fix scaling bug in current data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#851 fix scaling bug in current data pybamm-team/PyBaMM
1 participant
@rtimms