-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 632 average second dimension #1057
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1057 +/- ##
===========================================
+ Coverage 97.63% 97.72% +0.08%
===========================================
Files 237 237
Lines 12386 12426 +40
===========================================
+ Hits 12093 12143 +50
+ Misses 293 283 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Tino, thanks! Just the comment on uncommenting some of the models in compare_lead_acid.py
.
# pybamm.lead_acid.LOQS(), | ||
# pybamm.lead_acid.FOQS(), | ||
pybamm.lead_acid.Composite(), | ||
# pybamm.lead_acid.Full(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should not be commented.
Description
Add functionality to allow averaging in a secondary dimension (for example, averaging particle concentrations in the x-dimension in the DFN)
Fixes #632
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: