Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1225 slow sei model #1227

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

Description

Avoid try-except block which was causing the EC SEI submodel to slow down because of the levenshtein ratio search

Fixes #1225

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #1227 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1227      +/-   ##
===========================================
- Coverage    97.92%   97.92%   -0.01%     
===========================================
  Files          249      249              
  Lines        14146    14144       -2     
===========================================
- Hits         13852    13850       -2     
  Misses         294      294              
Impacted Files Coverage Δ
...els/submodels/interface/sei/ec_reaction_limited.py 100.00% <100.00%> (ø)
...models/submodels/interface/sei/reaction_limited.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51df9f...619d09a. Read the comment docs.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Tino! There is the issue with Codecov but I think we can merge anyway (basically the missed lines haven't changed, so that should be fine).

@valentinsulzer valentinsulzer merged commit d24bd41 into develop Nov 2, 2020
@valentinsulzer valentinsulzer deleted the issue-1225-slow-sei-model branch November 2, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model with EC SEI submodel takes long time to build
2 participants