Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1063 tplus temperature dependent #1317

Conversation

brosaplanella
Copy link
Sponsor Member

@brosaplanella brosaplanella commented Jan 2, 2021

Description

The transference number t_plus is now a function of both electrolyte concentration and temperature. For lead-acid, the temperature dependence is ignored, as it happened with the other parameters.

Fixes #1063

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@brosaplanella brosaplanella requested review from rtimms, valentinsulzer and TomTranter and removed request for rtimms January 2, 2021 20:06
@brosaplanella
Copy link
Sponsor Member Author

@tinosulzer if you can, take a look to the lead-acid part. I think I have implemented the same hack as with the other parameters, but I might have missed something.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #1317 (17cbfb7) into develop (faa3167) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1317   +/-   ##
========================================
  Coverage    98.11%   98.11%           
========================================
  Files          272      272           
  Lines        15339    15340    +1     
========================================
+ Hits         15050    15051    +1     
  Misses         289      289           
Impacted Files Coverage Δ
...models/full_battery_models/lead_acid/basic_full.py 100.00% <ø> (ø)
...odels/full_battery_models/lithium_ion/basic_dfn.py 100.00% <ø> (ø)
..._battery_models/lithium_ion/basic_dfn_half_cell.py 99.31% <ø> (ø)
...els/electrolyte_diffusion/first_order_diffusion.py 100.00% <ø> (ø)
...2019/electrolyte_TDF_EC_DMC_1_1_Landesfeind2019.py 100.00% <100.00%> (ø)
..._transference_number_EC_DMC_1_1_Landesfeind2019.py 100.00% <100.00%> (ø)
...2019/electrolyte_TDF_EC_EMC_3_7_Landesfeind2019.py 100.00% <100.00%> (ø)
..._transference_number_EC_EMC_3_7_Landesfeind2019.py 100.00% <100.00%> (ø)
...19/electrolyte_TDF_EMC_FEC_19_1_Landesfeind2019.py 100.00% <100.00%> (ø)
...ransference_number_EMC_FEC_19_1_Landesfeind2019.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa3167...17cbfb7. Read the comment docs.

@valentinsulzer
Copy link
Member

Happy for you to merge this, failing test is clearly just a github actions bug

@brosaplanella brosaplanella merged commit cd833d0 into pybamm-team:develop Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make thermodynamic factor and transference number temperature dependent
2 participants