Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1325 add error messages #1326

Merged
merged 5 commits into from
Jan 14, 2021
Merged

Conversation

valentinsulzer
Copy link
Member

Description

Adds error message when the initial conditions are outside the bounds of the variable.

Fixes #1325

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1326 (8132da6) into develop (77e0767) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1326   +/-   ##
========================================
  Coverage    98.12%   98.12%           
========================================
  Files          272      272           
  Lines        15431    15439    +8     
========================================
+ Hits         15142    15150    +8     
  Misses         289      289           
Impacted Files Coverage Δ
pybamm/expression_tree/input_parameter.py 100.00% <ø> (ø)
pybamm/discretisations/discretisation.py 99.78% <100.00%> (+<0.01%) ⬆️
pybamm/solvers/casadi_algebraic_solver.py 98.71% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e0767...8132da6. Read the comment docs.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thanks Tino! Before merging we should add a line to the CHANGELOG.

@valentinsulzer valentinsulzer merged commit 948505e into develop Jan 14, 2021
@valentinsulzer valentinsulzer deleted the issue-1325-better-error-messages branch January 14, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants