Issue 1082 events

[valentinsulzer]

Description

Add a new casadi solver mode which provides a fast solution even when there are events. Eventually this could become the default mode for the casadi solver, but it needs more testing first.

Should not be part of v0.4.0, do not merge before #1448

Fixes #1082

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #1450 (f280a92) into develop (4df4220) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1450      +/-   ##
===========================================
+ Coverage    98.28%   98.30%   +0.01%     
===========================================
  Files          281      281              
  Lines        16219    16313      +94     
===========================================
+ Hits         15941    16036      +95     
+ Misses         278      277       -1     

Impacted Files	Coverage Δ
...graphite_UMBL_Mohtat2020/graphite_ocp_PeymanMPM.py	100.00% <ø> (ø)
...lectrodes/NMC_UMBL_Mohtat2020/NMC_ocp_PeymanMPM.py	100.00% <ø> (ø)
pybamm/models/submodels/particle/base_particle.py	100.00% <ø> (ø)
pybamm/solvers/casadi_algebraic_solver.py	98.87% <ø> (ø)
pybamm/models/event.py	95.83% <100.00%> (+4.52%)	⬆️
...m/models/full_battery_models/base_battery_model.py	99.67% <100.00%> (+<0.01%)	⬆️
...ybamm/models/submodels/interface/base_interface.py	99.62% <100.00%> (+<0.01%)	⬆️
pybamm/parameters/lithium_ion_parameters.py	100.00% <100.00%> (ø)
pybamm/simulation.py	97.99% <100.00%> (+0.04%)	⬆️
pybamm/solvers/base_solver.py	99.18% <100.00%> (+0.03%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df4220...f280a92. Read the comment docs.

[brosaplanella]

Looks good, thanks Tino! On Monday I will test it with the new parameter set I am working on which gave some issues in terms of speed.

[valentinsulzer]

Cool, hope it helps!

[rtimms]

thanks @tinosulzer !