-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganised functions.py and updated functions.rst #1628
Reorganised functions.py and updated functions.rst #1628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Bence! Looks good, just see the comment about the duplication. Happy to merge if the tests pass :).
EDIT: Also, can you add a line to the CHANGELOG with the changes you have done?
Remove duplicate line
Removed empty line
Update the changelog
The changelog should now be updated as well. |
Codecov Report
@@ Coverage Diff @@
## develop #1628 +/- ##
=========================================
Coverage 99.26% 99.26%
=========================================
Files 326 343 +17
Lines 18529 18677 +148
=========================================
+ Hits 18392 18540 +148
Misses 137 137
Continue to review full report at Codecov.
|
@all-contributors add @partben for docs |
@tinosulzer I've put up a pull request to add @partben! 🎉 |
Description
Reformatted functions.py so that everything is in alphabetical order, and updated functions.rst so that it includes everything in functions.py.
Fixes #1623
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: