#1722 store first states #1759
Merged
#1722 store first states #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1759 +/- ##
========================================
Coverage 99.28% 99.28%
========================================
Files 343 343
Lines 18894 18900 +6
========================================
+ Hits 18759 18765 +6
Misses 135 135
Continue to review full report at Codecov.
|
| @@ -935,6 +945,7 @@ def solve( | |||
| if self.solution is not None and len(all_cycle_solutions) > 0: | |||
| self.solution.cycles = all_cycle_solutions | |||
| self.solution.set_summary_variables(all_summary_variables) | |||
| self.solution.all_first_states = all_first_states | |||
There was a problem hiding this comment.
couldn't this whole PR be a one-liner with
self.solution.all_first_states = [cycle.first_state for cycle in self.solution.cycles]There was a problem hiding this comment.
I have tried and it doesn't work because if the cycle is not stored cycle is None so you can't pull the first state.
There was a problem hiding this comment.
I forgot that's why we were doing this in the first place haha
valentinsulzer
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a variable to the solution called
all_first_stateswhich is a list of thefirst_stateof each cycle.Fixes #1722
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: