-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1781 utilization #1821
Issue 1781 utilization #1821
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1821 +/- ##
=========================================
Coverage 99.25% 99.26%
=========================================
Files 340 345 +5
Lines 18773 18900 +127
=========================================
+ Hits 18634 18761 +127
Misses 139 139
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small comments.
@@ -3,7 +3,7 @@ | |||
# | |||
import pybamm | |||
|
|||
pybamm.set_logging_level("INFO") | |||
pybamm.set_logging_level("DEBUG") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set it back to INFO?
@@ -20,4 +20,6 @@ | |||
sims.append(sim) | |||
|
|||
# plot | |||
pybamm.dynamic_plot(sims) | |||
pybamm.dynamic_plot( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we revert it?
def test_constant_utilisation(self): | ||
options = {"interface utilisation": "constant"} | ||
parameter_values = pybamm.ParameterValues( | ||
chemistry=pybamm.parameter_sets.Marquis2019 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hasn't the keyword argument been deprecated?
Description
Fixes #1781
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: