Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to casadi 3.6.4 for Windows wheels #3637

Merged

Conversation

agriyakhetarpal
Copy link
Member

Description

See #3193 and #3100. The pybamm-team/casadi-vcpkg-registry has been updated to use casadi==3.6.4 for linkage in the Windows wheels. We should ensure that the version of casadi used for IDAKLU compilation remains the same across platforms and architectures, for which #3603 has been opened.

The wheels have been built with this update earlier on my fork and had passed as noted in #3100. The issue has been noted to be fixed for the Windows wheels with this change.

Fixes #3100

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e72c38) 99.59% compared to head (c14ed01) 99.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3637   +/-   ##
========================================
  Coverage    99.59%   99.59%           
========================================
  Files          258      258           
  Lines        20797    20797           
========================================
  Hits         20712    20712           
  Misses          85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agriyakhetarpal

This comment has been minimized.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @agriyakhetarpal!

@Saransh-cpp Saransh-cpp merged commit 0369f0c into pybamm-team:develop Jan 6, 2024
41 checks passed
@agriyakhetarpal agriyakhetarpal deleted the casadi-windows-wheels branch January 6, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: IDAKLU / casadi serialization error - Object written in version 2 but can only read in version 1
2 participants