-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cron schedule for PyPI publishing workflow and add cache for vcpkg dependencies #3792
Conversation
…cpkg dependencies
@R-Yash Can you fix the conflicts so the review can be started? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3792 +/- ##
========================================
Coverage 99.59% 99.59%
========================================
Files 257 257
Lines 20802 20802
========================================
Hits 20718 20718
Misses 84 84 ☔ View full report in Codecov by Sentry. |
- name: Cache vcpkg dependencies | ||
if: matrix.os == 'windows-latest' | ||
uses: actions/cache@v2 | ||
with: | ||
path: ~/.cache/vcpkg | ||
key: ${{ runner.os }}-vcpkg-${{ hashFiles('**/vcpkg.json') }} | ||
restore-keys: | | ||
${{ runner.os }}-vcpkg- | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides this, we also need the PyBaMM-related environment variables, such as PYBAMM_USE_VCPKG_ON, CMAKE_BUILD_PARALLEL_LEVEL, and the rest present in publish_pypi.py
so that setup.py
can use all features of vcpkg
.
After you add all of those, I would suggest triggering this workflow from this branch to test these changes (if you do it correctly, you should see a win-amd64
file being built for PyBaMM rather than the current none-any.whl
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agriyakhetarpal How can I trigger a workflow from this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arjxn-py. Also, these environment variables have been set for the entire matrix. We need these just for the Windows steps in the job. We don't have separate Windows steps, so you can create a separate step with Run integration tests on Windows
and add these environment variables there (similarly for unit tests, etc.)
@R-Yash, feel free to ask if you need help with anything! |
@R-Yash are you still working on this? |
Let's close this, actually. We could wait for a while, but not only has the contributor been unresponsive, but also that this is likely stalled until we have a resolution for #3783 (the PyBaMM IDAKLU solver is broken on Windows even if one installs from source). Please feel free to reopen this as you feel fit, @R-Yash! |
Update cron schedule for PyPI publishing workflow and add cache for vcpkg dependencies
Description
Added a process to cache vcpkg dependencies in
run_periodic_tests.yaml
and made the tests run every week by editingpublish_pypi.yaml
Fixes #3664
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: