Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 600 interpolate #661

Merged

Conversation

valentinsulzer
Copy link
Member

Description

Add Interpolant class to interpolate experimental data (e.g. OCP curves).

Fixes #600

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Any dependent changes have been merged and published in downstream modules

@valentinsulzer valentinsulzer changed the base branch from master to issue-563-parameters-by-material October 14, 2019 02:00
@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #661 into issue-563-parameters-by-material will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                         Coverage Diff                          @@
##           issue-563-parameters-by-material     #661      +/-   ##
====================================================================
+ Coverage                             98.52%   98.53%   +<.01%     
====================================================================
  Files                                   168      169       +1     
  Lines                                  8226     8255      +29     
====================================================================
+ Hits                                   8105     8134      +29     
  Misses                                  121      121
Impacted Files Coverage Δ
pybamm/parameters/parameter_values.py 99.47% <100%> (+0.01%) ⬆️
pybamm/expression_tree/functions.py 100% <100%> (ø) ⬆️
pybamm/expression_tree/simplify.py 94.98% <100%> (ø) ⬆️
pybamm/expression_tree/interpolant.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004b1f7...6d0628a. Read the comment docs.

@@ -0,0 +1,50 @@
0.000000000000000000e+00 4.714135898019971016e+00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should agree on a format for the data (like headers, where the data comes from...).

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @tinosulzer!

@valentinsulzer valentinsulzer merged commit ee96fea into issue-563-parameters-by-material Oct 14, 2019
@valentinsulzer valentinsulzer deleted the issue-600-interpolate branch October 14, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants