Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#668 add evaluate function #669

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Conversation

valentinsulzer
Copy link
Member

Description

Add function to evaluate parameters more easily.
Fixes #668

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #669 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   98.54%   98.54%   +<.01%     
==========================================
  Files         169      169              
  Lines        8436     8441       +5     
==========================================
+ Hits         8313     8318       +5     
  Misses        123      123
Impacted Files Coverage Δ
...ollector/effective_resistance_current_collector.py 96.29% <100%> (ø) ⬆️
pybamm/parameters/parameter_values.py 99.48% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1028e78...eff4381. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @tinosulzer !

@valentinsulzer valentinsulzer merged commit 79c9d34 into master Oct 19, 2019
@valentinsulzer valentinsulzer deleted the issue-668-evaluate-parameters branch October 19, 2019 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method to evaluate parameters
2 participants