Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 570 processed var warning #681

Merged
merged 5 commits into from
Oct 25, 2019

Conversation

valentinsulzer
Copy link
Member

Description

Add warning if processed variable is called outside range
Fixes #570

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thanks @tinosulzer !

@@ -12,7 +17,5 @@

# Create a custom logger
logger = logging.getLogger(__name__)
set_logging_level("WARNING")
Copy link
Contributor

@rtimms rtimms Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the test_logger test needs updating as the default logger level has changed

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #681 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   98.56%   98.56%   +<.01%     
==========================================
  Files         170      170              
  Lines        8517     8521       +4     
==========================================
+ Hits         8395     8399       +4     
  Misses        122      122
Impacted Files Coverage Δ
pybamm/quick_plot.py 96.75% <ø> (ø) ⬆️
pybamm/processed_variable.py 97.23% <100%> (+0.03%) ⬆️
pybamm/logger.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46b47a1...2962b1d. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 9d3ea6b into master Oct 25, 2019
@valentinsulzer valentinsulzer deleted the issue-570-processed-var-warning branch October 25, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

processed variable error when t,x,or r outside of range
2 participants