-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 744 particledistribution #745
Issue 744 particledistribution #745
Conversation
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 98.38% 98.39% +<.01%
==========================================
Files 176 176
Lines 9678 9701 +23
==========================================
+ Hits 9522 9545 +23
Misses 156 156
Continue to review full report at Codecov.
|
…PyBaMM into issue-744-particledistribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks!
@@ -11,6 +11,7 @@ Negative electrode OCP [V],[function]graphite_mcmb2528_ocp_Dualfoil1998, | |||
Negative electrode porosity,0.3,Scott Moura FastDFN,electrolyte volume fraction | |||
Negative electrode active material volume fraction,0.7,,assuming zero binder volume fraction | |||
Negative particle radius [m],1E-05,Scott Moura FastDFN, | |||
Negative particle distribution,1,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth having a comment here just to make it clear that this is a size distribution in x, rather than a distribution of particle sizes at each x?
…PyBaMM into issue-744-particledistribution
Description
Added particle size distribution in x to the DFN model.
Fixes #744
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: