Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 746 broadcasting #747

Merged
merged 7 commits into from
Nov 26, 2019
Merged

Issue 746 broadcasting #747

merged 7 commits into from
Nov 26, 2019

Conversation

valentinsulzer
Copy link
Member

Description

Remove outers and primary broadcasts from some models and do it automatically instead.

Fixes #746

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thanks @tinosulzer ! much more user friendly now (once tests are fixed!)

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #747 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   98.35%   98.36%   +<.01%     
==========================================
  Files         175      175              
  Lines        9599     9880     +281     
==========================================
+ Hits         9441     9718     +277     
- Misses        158      162       +4
Impacted Files Coverage Δ
...models/particle/fickian/fickian_single_particle.py 100% <ø> (ø) ⬆️
pybamm/models/submodels/thermal/base_thermal.py 92.5% <ø> (ø) ⬆️
pybamm/spatial_methods/spatial_method.py 95.12% <100%> (+0.06%) ⬆️
pybamm/expression_tree/binary_operators.py 98.87% <100%> (+0.02%) ⬆️
...amm/models/submodels/convection/base_convection.py 100% <100%> (ø) ⬆️
...odels/submodels/convection/composite_convection.py 100% <100%> (ø) ⬆️
.../models/submodels/convection/leading_convection.py 100% <100%> (ø) ⬆️
...ll/diffusion/composite_stefan_maxwell_diffusion.py 96.96% <100%> (-0.09%) ⬇️
...m/full_surface_form_stefan_maxwell_conductivity.py 100% <100%> (ø) ⬆️
...onductivity/leading_stefan_maxwell_conductivity.py 100% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a0c23...811c8da. Read the comment docs.

@valentinsulzer valentinsulzer merged commit d8d24c6 into master Nov 26, 2019
@valentinsulzer valentinsulzer deleted the issue-746-broadcasting branch November 26, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic broadcasting
2 participants