Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 762 casadi mass #769

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Issue 762 casadi mass #769

merged 3 commits into from
Jan 6, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Jan 2, 2020

Description

Automatically computes the inverse of the mass matrix during discretisation so that the resulting system of DAEs can be provided in semi explicit form, which is required by the casadi solver

Fixes #762

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #769 into master will increase coverage by <.01%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
+ Coverage   98.38%   98.38%   +<.01%     
==========================================
  Files         179      179              
  Lines        9894     9916      +22     
==========================================
+ Hits         9734     9756      +22     
  Misses        160      160
Impacted Files Coverage Δ
pybamm/models/base_model.py 98.65% <100%> (+0.03%) ⬆️
pybamm/discretisations/discretisation.py 99.74% <100%> (ø) ⬆️
pybamm/solvers/dae_solver.py 100% <100%> (ø) ⬆️
pybamm/solvers/ode_solver.py 98.08% <100%> (+0.01%) ⬆️
pybamm/solvers/casadi_solver.py 97.67% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3098ec6...39cda77. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @rtimms . Don't forget to update changelog

@rtimms rtimms merged commit 1e39620 into master Jan 6, 2020
@rtimms rtimms deleted the issue-762-casadi-mass branch January 6, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-identity mass in casadi
2 participants