Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 774 remove outer kron #777

Merged
merged 10 commits into from
Jan 10, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

Description

Remove Outer and Kron nodes as they are no longer needed

Fixes #774

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #777 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   98.42%   98.44%   +0.01%     
==========================================
  Files         179      179              
  Lines        9931     9890      -41     
==========================================
- Hits         9775     9736      -39     
+ Misses        156      154       -2
Impacted Files Coverage Δ
pybamm/expression_tree/operations/evaluate.py 95.65% <ø> (+0.86%) ⬆️
pybamm/discretisations/discretisation.py 99.74% <ø> (-0.01%) ⬇️
...mm/expression_tree/operations/convert_to_casadi.py 100% <100%> (ø) ⬆️
pybamm/expression_tree/binary_operators.py 99.05% <100%> (+0.18%) ⬆️
pybamm/spatial_methods/spatial_method.py 95.78% <100%> (+0.23%) ⬆️
pybamm/expression_tree/operations/jacobian.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1395e5...ff48fcb. Read the comment docs.

@valentinsulzer valentinsulzer changed the base branch from issue-771-secondary-broadcast to master January 10, 2020 13:49
Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks

@valentinsulzer valentinsulzer merged commit b48074f into master Jan 10, 2020
@valentinsulzer valentinsulzer deleted the issue-774-remove-outer-kron branch January 10, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Outer and Kron
2 participants