Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 749 cache symbol shape #780

Merged
merged 14 commits into from
Jan 10, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

Description

Save symbol shapes when they have already been evaluated

Fixes #749

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d05306b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #780   +/-   ##
=========================================
  Coverage          ?   98.43%           
=========================================
  Files             ?      179           
  Lines             ?     9937           
  Branches          ?        0           
=========================================
  Hits              ?     9781           
  Misses            ?      156           
  Partials          ?        0
Impacted Files Coverage Δ
pybamm/models/standard_variables.py 100% <ø> (ø)
pybamm/expression_tree/binary_operators.py 98.87% <100%> (ø)
pybamm/expression_tree/concatenations.py 97.95% <100%> (ø)
pybamm/models/submodels/particle/base_particle.py 97.29% <100%> (ø)
pybamm/expression_tree/unary_operators.py 96.14% <100%> (ø)
pybamm/expression_tree/broadcasts.py 100% <100%> (ø)
pybamm/expression_tree/operations/jacobian.py 100% <100%> (ø)
pybamm/spatial_methods/spatial_method.py 95.55% <100%> (ø)
pybamm/expression_tree/functions.py 100% <100%> (ø)
pybamm/spatial_methods/finite_volume.py 97.46% <100%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05306b...4e93f1b. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 23aea3d into master Jan 10, 2020
@valentinsulzer valentinsulzer deleted the issue-749-cache-symbol-shape branch January 10, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache symbol shapes for testing
2 participants