Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#803 make visualise fail only raise logger error #810

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Make visualise raise a logger error only if graphviz is not installed (so that graphviz is an optional dependency)
Fixes #803

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #810 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   98.14%   98.12%   -0.02%     
==========================================
  Files         179      179              
  Lines        9919     9922       +3     
==========================================
+ Hits         9735     9736       +1     
- Misses        184      186       +2
Impacted Files Coverage Δ
pybamm/expression_tree/symbol.py 96.99% <50%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f417cb...d6caf83. Read the comment docs.

@valentinsulzer valentinsulzer merged commit f68b303 into master Feb 12, 2020
@valentinsulzer valentinsulzer deleted the issue-803-graphviz branch February 12, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After install and run-tests, I have following errors.
2 participants