-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 882 la thermal #885
Issue 882 la thermal #885
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #885 +/- ##
===========================================
+ Coverage 97.78% 97.79% +<.01%
===========================================
Files 210 210
Lines 10582 10603 +21
===========================================
+ Hits 10348 10369 +21
Misses 234 234
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Description
Added thermal parameters for lead-acid to the parameter files and added the tests.
Fixes # 882
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: