Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 882 la thermal #885

Merged
merged 9 commits into from
Mar 13, 2020

Conversation

viviantran27
Copy link
Contributor

Description

Added thermal parameters for lead-acid to the parameter files and added the tests.

Fixes # 882

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #885 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #885      +/-   ##
===========================================
+ Coverage    97.78%   97.79%   +<.01%     
===========================================
  Files          210      210              
  Lines        10582    10603      +21     
===========================================
+ Hits         10348    10369      +21     
  Misses         234      234
Impacted Files Coverage Δ
pybamm/solvers/casadi_algebraic_solver.py 100% <ø> (ø) ⬆️
pybamm/solvers/algebraic_solver.py 100% <ø> (ø) ⬆️
...9/electrolyte_conductivity_Landesfeind2019_base.py 100% <100%> (ø) ⬆️
...olyte_conductivity_Landesfeind2019_EMC_FEC_19_1.py 100% <100%> (ø) ⬆️
...trolyte_conductivity_Landesfeind2019_EC_EMC_3_7.py 100% <100%> (ø) ⬆️
...m/models/full_battery_models/base_battery_model.py 100% <100%> (ø) ⬆️
...ctrolyte_diffusivity_Landesfeind2019_EC_DMC_1_1.py 100% <100%> (ø) ⬆️
...rolyte_diffusivity_Landesfeind2019_EMC_FEC_19_1.py 100% <100%> (ø) ⬆️
...ctrolyte_diffusivity_Landesfeind2019_EC_EMC_3_7.py 100% <100%> (ø) ⬆️
...trolyte_conductivity_Landesfeind2019_EC_DMC_1_1.py 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14dff27...5088847. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@valentinsulzer valentinsulzer merged commit 986ff2c into pybamm-team:develop Mar 13, 2020
@viviantran27 viviantran27 deleted the issue-882-LA_thermal branch August 1, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants