Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 825 tplus #921

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Issue 825 tplus #921

merged 3 commits into from
Mar 27, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Make t_plus and (1 + dlnf/dlnc) functions of c_e

Fixes #825

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #921 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #921   +/-   ##
========================================
  Coverage    98.00%   98.00%           
========================================
  Files          208      208           
  Lines        10929    10931    +2     
========================================
+ Hits         10711    10713    +2     
  Misses         218      218           
Impacted Files Coverage Δ
...l_battery_models/lead_acid/base_lead_acid_model.py 100.00% <ø> (ø)
...ttery_models/lithium_ion/base_lithium_ion_model.py 100.00% <ø> (ø)
...odels/full_battery_models/lithium_ion/basic_dfn.py 100.00% <ø> (ø)
.../diffusion/first_order_stefan_maxwell_diffusion.py 100.00% <ø> (ø)
...well/diffusion/leading_stefan_maxwell_diffusion.py 100.00% <ø> (ø)
...y/base_higher_order_stefan_maxwell_conductivity.py 98.07% <100.00%> (-0.14%) ⬇️
...ll/diffusion/composite_stefan_maxwell_diffusion.py 97.22% <100.00%> (+0.25%) ⬆️
...maxwell/diffusion/full_stefan_maxwell_diffusion.py 100.00% <100.00%> (ø)
pybamm/parameters/standard_parameters_lead_acid.py 99.25% <100.00%> (-0.01%) ⬇️
...bamm/parameters/standard_parameters_lithium_ion.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d6143...38d6724. Read the comment docs.

Copy link
Contributor

@Scottmar93 Scottmar93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, looks good

@valentinsulzer valentinsulzer merged commit 13a0ca0 into develop Mar 27, 2020
@valentinsulzer valentinsulzer deleted the issue-825-tplus branch March 27, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make transference number a function
2 participants