Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 939 sim defaults #952

Merged
merged 6 commits into from
Apr 13, 2020
Merged

Issue 939 sim defaults #952

merged 6 commits into from
Apr 13, 2020

Conversation

valentinsulzer
Copy link
Member

Description

  • Add default parameter values, etc to the base model
  • Copy attributes before assigning them to the simulation to avoid them changing unexpectedly
  • Remove the C-rate parameter, except for using via the simulation

Fixes #939

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #952 into develop will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #952      +/-   ##
===========================================
+ Coverage    98.06%   98.08%   +0.02%     
===========================================
  Files          220      220              
  Lines        11370    11361       -9     
===========================================
- Hits         11150    11144       -6     
+ Misses         220      217       -3     
Impacted Files Coverage Δ
pybamm/models/base_model.py 98.63% <100.00%> (+0.04%) ⬆️
pybamm/parameters/parameter_values.py 99.08% <100.00%> (-0.15%) ⬇️
pybamm/parameters/print_parameters.py 97.14% <100.00%> (+0.17%) ⬆️
pybamm/simulation.py 98.41% <100.00%> (+1.36%) ⬆️
pybamm/solvers/base_solver.py 99.48% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d7b87...76c5560. Read the comment docs.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@valentinsulzer valentinsulzer merged commit d637f9b into develop Apr 13, 2020
@valentinsulzer valentinsulzer deleted the issue-939-sim-defaults branch April 13, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulation expecting defaults
2 participants