Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#961 fix interpolant ids #962

Merged
merged 2 commits into from
Apr 17, 2020
Merged

#961 fix interpolant ids #962

merged 2 commits into from
Apr 17, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Change interpolant id so that different interpolants have different ids

Fixes #961

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #962 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #962   +/-   ##
========================================
  Coverage    98.11%   98.11%           
========================================
  Files          221      221           
  Lines        11518    11528   +10     
========================================
+ Hits         11301    11311   +10     
  Misses         217      217           
Impacted Files Coverage Δ
pybamm/expression_tree/interpolant.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b72b1e...c93b6c8. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 2382672 into develop Apr 17, 2020
@valentinsulzer valentinsulzer deleted the issue-961-interpolants branch April 17, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processing Interpolants bug
3 participants