Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 966 exchange current #975

Merged
merged 5 commits into from
May 1, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Apr 30, 2020

Description

Make "exchange-current density" a parameter instead of "reaction rate".
Also replaced "surface area density" with "surface area to volume ratio"

Fixes #966

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #975 into develop will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #975      +/-   ##
===========================================
+ Coverage    97.48%   97.50%   +0.02%     
===========================================
  Files          222      225       +3     
  Lines        11791    11830      +39     
===========================================
+ Hits         11494    11535      +41     
+ Misses         297      295       -2     
Impacted Files Coverage Δ
...dels/submodels/interface/kinetics/base_kinetics.py 100.00% <ø> (ø)
pybamm/solvers/casadi_solver.py 100.00% <ø> (ø)
...er2019/lead_exchange_current_density_Sulzer2019.py 100.00% <100.00%> (ø)
...ead_dioxide_exchange_current_density_Sulzer2019.py 100.00% <100.00%> (ø)
...2019/oxygen_exchange_current_density_Sulzer2019.py 100.00% <100.00%> (ø)
...0_electrolyte_exchange_current_density_Chen2020.py 100.00% <100.00%> (ø)
..._electrolyte_exchange_current_density_Ecker2015.py 100.00% <100.00%> (ø)
...te_electrolyte_exchange_current_density_Kim2011.py 100.00% <100.00%> (ø)
..._electrolyte_exchange_current_density_PeymanMPM.py 100.00% <100.00%> (ø)
...ectrolyte_exchange_current_density_Dualfoil1998.py 100.00% <100.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fba98...6d7abdd. Read the comment docs.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Tino! Just a minor comment about some commented lines (do we want to leave them there?).

U_n_Ox = (U_Ox_dim - U_n_ref) / potential_scale
U_p_Ox = (U_Ox_dim - U_p_ref) / potential_scale
# Hydrogen
s_plus_Hy = s_plus_Hy_dim / ne_Hy
s_hy_Hy = s_hy_Hy_dim / ne_Hy
j0_n_Hy_ref = j0_n_Hy_ref_dimensional / interfacial_current_scale_n
j0_p_Hy_ref = j0_p_Hy_ref_dimensional / interfacial_current_scale_p
# j0_n_Hy_ref = j0_n_Hy_ref_dimensional / interfacial_current_scale_n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these lines left commented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No good reason, I will delete them

@valentinsulzer valentinsulzer merged commit 1bdbdaf into develop May 1, 2020
@valentinsulzer valentinsulzer deleted the issue-966-exchange-current branch May 1, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exchange current density
2 participants