-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 966 exchange current #975
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #975 +/- ##
===========================================
+ Coverage 97.48% 97.50% +0.02%
===========================================
Files 222 225 +3
Lines 11791 11830 +39
===========================================
+ Hits 11494 11535 +41
+ Misses 297 295 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Tino! Just a minor comment about some commented lines (do we want to leave them there?).
U_n_Ox = (U_Ox_dim - U_n_ref) / potential_scale | ||
U_p_Ox = (U_Ox_dim - U_p_ref) / potential_scale | ||
# Hydrogen | ||
s_plus_Hy = s_plus_Hy_dim / ne_Hy | ||
s_hy_Hy = s_hy_Hy_dim / ne_Hy | ||
j0_n_Hy_ref = j0_n_Hy_ref_dimensional / interfacial_current_scale_n | ||
j0_p_Hy_ref = j0_p_Hy_ref_dimensional / interfacial_current_scale_p | ||
# j0_n_Hy_ref = j0_n_Hy_ref_dimensional / interfacial_current_scale_n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these lines left commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No good reason, I will delete them
Description
Make "exchange-current density" a parameter instead of "reaction rate".
Also replaced "surface area density" with "surface area to volume ratio"
Fixes #966
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: