-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 984 butler volmer resistance #994
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #994 +/- ##
===========================================
+ Coverage 97.56% 97.58% +0.01%
===========================================
Files 232 234 +2
Lines 12119 12251 +132
===========================================
+ Hits 11824 11955 +131
- Misses 295 296 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tino! It looks great :D
Description
Fix some bugs in the SEI submodels and add the SEI film resistance.
Note: we may want to think about the nondimensionalisation for the SEI a bit more
Fixes #984
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: