Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 984 butler volmer resistance #994

Merged
merged 19 commits into from
May 19, 2020

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented May 14, 2020

Description

Fix some bugs in the SEI submodels and add the SEI film resistance.

Note: we may want to think about the nondimensionalisation for the SEI a bit more

Fixes #984

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #994 into develop will increase coverage by 0.01%.
The diff coverage is 98.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #994      +/-   ##
===========================================
+ Coverage    97.56%   97.58%   +0.01%     
===========================================
  Files          232      234       +2     
  Lines        12119    12251     +132     
===========================================
+ Hits         11824    11955     +131     
- Misses         295      296       +1     
Impacted Files Coverage Δ
...bamm/models/full_battery_models/lithium_ion/dfn.py 100.00% <ø> (ø)
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)
pybamm/parameters/parameter_values.py 99.56% <80.00%> (-0.08%) ⬇️
pybamm/models/submodels/interface/sei/base_sei.py 95.91% <83.33%> (ø)
...ybamm/models/submodels/interface/base_interface.py 99.59% <95.00%> (-0.41%) ⬇️
...m/models/full_battery_models/base_battery_model.py 99.62% <100.00%> (+0.02%) ⬆️
...l_battery_models/lead_acid/base_lead_acid_model.py 100.00% <100.00%> (ø)
...ybamm/models/full_battery_models/lead_acid/full.py 100.00% <100.00%> (ø)
...dels/full_battery_models/lead_acid/higher_order.py 98.07% <100.00%> (+0.01%) ⬆️
...ybamm/models/full_battery_models/lead_acid/loqs.py 100.00% <100.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d99e2a...3f1629c. Read the comment docs.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tino! It looks great :D

@valentinsulzer valentinsulzer merged commit dbe7b80 into develop May 19, 2020
@valentinsulzer valentinsulzer deleted the issue-984-butler-volmer-resistance branch May 19, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resistance in Butler-Volmer
2 participants