Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs #163

Merged
merged 11 commits into from
Jul 1, 2022
Merged

Fix docs #163

merged 11 commits into from
Jul 1, 2022

Conversation

TomTranter
Copy link
Collaborator

No description provided.

@TomTranter TomTranter linked an issue Jun 9, 2022 that may be closed by this pull request
@TomTranter
Copy link
Collaborator Author

@Saransh-cpp after some playing I switched to using conda to build the packages instead of pip. I added some specific mkdocs dependencies to the environment.yml though. Is there a way to only install these with a [docs] type argument?

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #163 (5846890) into main (24bc5a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          11       11           
  Lines        1272     1272           
=======================================
  Hits         1232     1232           
  Misses         40       40           

@Saransh-cpp
Copy link
Member

AFAIK conda doesn't support adding tags or arguments for dependencies. This answer suggests adding a new environment.yml file (maybe named environment.docs.yml) with only the docs requirements and using both of them to setup an environment for docs.

@TomTranter
Copy link
Collaborator Author

TomTranter commented Jun 10, 2022

@Saransh-cpp this would be a good solution if I could figure out how to run any bespoke conda commands automatically using read the docs it seems all it lets you do is define a single environment.yml to run. There are bepoke build commands for when you are not using conda. I hesitate to add the dependencies to the package just for building the docs but seems like the simplest solution. Maybe @wigging has some thoughts?

@TomTranter
Copy link
Collaborator Author

The other equally unappealing option would be to just have a separate yml for docs with all the packages duplicated and the extra ones included.

@TomTranter
Copy link
Collaborator Author

I have submitted a question on read the docs about running bespoke conda commands

@TomTranter TomTranter merged commit adcd594 into main Jul 1, 2022
@TomTranter TomTranter deleted the protobuf branch July 1, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: protobuf version needs fixing
2 participants