Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate code and build library #4

Merged
merged 47 commits into from
Oct 3, 2024
Merged

Migrate code and build library #4

merged 47 commits into from
Oct 3, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Sep 26, 2024

Goals:

  • Basic tests of the import
  • Build locally and CI
  • Remove anything unneeded from build system
  • First pypi release (needed to remove IDAKLU source from pybamm)

Before review/merge:

  • Sync C/C++ code with PyBaMM

Progress

Building:

  • Nox (local and CI)
  • Linux wheels
  • Mac wheels
  • Windows wheels

Tested:

  • Mac install from wheels
  • Module import
  • PyBaMM functionality

Releasing:

  • Trusted publisher setup for pypi

Not covered in this workpackage:

  • Configure pre-commit
  • Using a build system other than nox/setuptools
  • IREE builds

@kratman kratman self-assigned this Sep 26, 2024
@kratman
Copy link
Contributor Author

kratman commented Sep 27, 2024

I have a temporary fix for the linking to casadi, I will replace this as I wrap up the PR

@kratman
Copy link
Contributor Author

kratman commented Sep 27, 2024

C++ code is synced as of pybamm-team/PyBaMM@62a7ee8

@kratman kratman marked this pull request as ready for review October 1, 2024 20:36
@kratman kratman requested a review from a team as a code owner October 1, 2024 20:36
@kratman
Copy link
Contributor Author

kratman commented Oct 2, 2024

@MarcBerliner Can you check this branch out and make sure it works locally for you?

Commands:

virtualenv .venv
source .venv/bin/activate
pip install nox
nox

This will trigger a single unit test that just checks if the idaklu module is importable.

Wheels for stand alone tests can be found here.

I also made a branch for removing idaklu from pybamm. I am not going to make a PR for it until pybammsolvers is on pypi so that the CI won't work until the release is done. The branch is here. Since the release is not available yet, you have to install the wheel first.

virtualenv .venv
source .venv/bin/activate
pip install pybammsolvers-0.0.1-<your_arch>.whl
pip install "[.all,dev]"

@kratman kratman merged commit 357ac25 into main Oct 3, 2024
7 checks passed
@kratman kratman deleted the feat/migrate branch October 3, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants